The new interface will move storage engine parameters into the database configuration and remove them from the knobs. It's now only for redwood, to create a database with specified parameters configure new <redundancy_mode> log_engine|storage_engine=<engine_type>:param1=val1,...,paramN=valN to change the existing storage servers configure storage_engine=<engine_type>:param1=val1,...,paramN=valN.

The parameters now only support redwood so setting it to other engines will give an error.

Storage engine params are written as \xff/conf/storage_engine_params/<param>:=<value>. When changing the parameters, it will also set a storageEngineParamsVersionKey ("\xff/conf/storage_engine_params"). There's an actor on DD monitoring this key and once it changed, DD will fetch the new parameters from \xff/conf/storage_engine_params/ and send requests to storage servers.

There are 3 types of parameters:

runtime: this will be changed by storage once receive the request
needReboot: storage will throw please_reboot_kv_store error which will reboot the kv store to start with the new param
needReplacement: DD will add servers into wiggler. If perpetual wiggle is enabled, it will start to wiggle the process out and when restart, they will use the new param

The way to check the storage parameters is to check the status json, the storage_metadata section will show the current storage parameters and ongoing wiggling parameters if there's any. E.g.

"storage_metadata": {
    "created_time_datetime":"1970-01-01 00:00:00.000 +0000",
     "created_time_timestamp": 0,
     "need_replacement":false,
     "params_need_to_be_replaced":[
        "page_size"
     ],
     "storage_engine":"ssd-redwood-1",
     "storage_parameters" : {
        "histogram_interval" : "30.000000",
        "kvstore_range_prefetch" : "true",
        "metrics_interval" : "5.000000",
        "page_size" : "8192",
        "remote_kv_store" : "false"
     }
 }

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Feb 21 '23 23:02 sfc-gh-clin

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 3e7a084238a938a91da6bbfbc110926d221c4c2d
Duration 0:32:04
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 3e7a084238a938a91da6bbfbc110926d221c4c2d
Duration 0:36:21
Result: :white_check_mark: SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 3e7a084238a938a91da6bbfbc110926d221c4c2d
Duration 0:40:37
Result: :x: FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: efc0b36f37dfb6c707e4462cd5260e7f4c93f7a3
Duration 0:04:24
Result: :x: FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

Commit ID: efc0b36f37dfb6c707e4462cd5260e7f4c93f7a3
Duration 0:04:29
Result: :x: FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: efc0b36f37dfb6c707e4462cd5260e7f4c93f7a3
Duration 0:04:48
Result: :x: FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: efc0b36f37dfb6c707e4462cd5260e7f4c93f7a3
Duration 0:06:59
Result: :x: FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 3e7a084238a938a91da6bbfbc110926d221c4c2d
Duration 0:53:38
Result: :x: FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

Feb 27 '23 18:02 foundationdb-ci