bindings/ Golang code conventions: Renamed error e to err

[LukasMoll]

#8828

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• [ ] The PR has a description, explaining both the problem and the solution.
• [ ] The description mentions which forms of testing were done and the testing seems reasonable.
• [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
• [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 3a4cc5bc0e35d83aa2846074e476cdd5b521d211
• Duration 0:17:40
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 3a4cc5bc0e35d83aa2846074e476cdd5b521d211
• Duration 0:20:28
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 3a4cc5bc0e35d83aa2846074e476cdd5b521d211
• Duration 0:26:39
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 3a4cc5bc0e35d83aa2846074e476cdd5b521d211
• Duration 0:27:12
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 3a4cc5bc0e35d83aa2846074e476cdd5b521d211
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[vishesh]

LGTM. There is one conflict that needs fixing.

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: eb7d26d22ec5f5054e3331c86367995047d73018
• Duration 0:17:17
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: eb7d26d22ec5f5054e3331c86367995047d73018
• Duration 0:22:03
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: eb7d26d22ec5f5054e3331c86367995047d73018
• Duration 0:26:50
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: eb7d26d22ec5f5054e3331c86367995047d73018
• Duration 0:26:56
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: eb7d26d22ec5f5054e3331c86367995047d73018
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[vishesh]

@LukasMoll : seems like there is still a conflict.

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:17:50
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:19:46
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:26:13
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:26:41
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:40:57
• Result: :x: FAILED
• Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS Monterey 12.x

• Commit ID: 392b2390010b8c0d22e1cf2f974e6a75f9e0e2a3
• Duration 0:46:52
• Result: :x: FAILED
• Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[ammolitor]

I just rebased this PR on top of apple:main and force pushed. Lets see what the CI builds tell us now.

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:18:07
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:20:36
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:24:47
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:25:52
• Result: :x: FAILED
• Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:41:22
• Result: :x: FAILED
• Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-macos on macOS Monterey 12.x

• Commit ID: 5734443d89bc38181cb490e56672fd23e8207b20
• Duration 0:48:42
• Result: :x: FAILED
• Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)

[ammolitor]

It looks like the go code does not compile yet.

FAILED: bindings/go/pkg/linux_amd64/github.com/apple/foundationdb/bindings/go/src/fdb.a /codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/go/pkg/linux_amd64/github.com/apple/foundationdb/bindings/go/src/fdb.a 
cd /codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/go && /usr/local/bin/cmake -E env GOPATH=/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/go C_INCLUDE_PATH=/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/c/foundationdb:/codebuild/output/src253030052/src/github.com/apple/foundationdb/bindings/c CGO_LDFLAGS=-L/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/lib GO111MODULE=auto /usr/local/go/bin/go get -d github.com/apple/foundationdb/bindings/go/src/fdb && /usr/local/bin/cmake -E env GOPATH=/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/go C_INCLUDE_PATH=/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/bindings/c/foundationdb:/codebuild/output/src253030052/src/github.com/apple/foundationdb/bindings/c CGO_LDFLAGS=-L/codebuild/output/src253030052/src/github.com/apple/foundationdb/build_output/lib GO111MODULE=auto /usr/local/go/bin/go install github.com/apple/foundationdb/bindings/go/src/fdb
# github.com/apple/foundationdb/bindings/go/src/fdb
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:136:8: undefined: err
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:139:6: undefined: err
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:146:17: undefined: err
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:147:4: undefined: err
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:152:6: undefined: err
src/github.com/apple/foundationdb/bindings/go/src/fdb/database.go:229:15: undefined: e

[fdb-windows-ci]

Doxense CI Report for Windows 10

• Commit ID: 3b023b75e912b343c440a4675268764ce8632934
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

[foundationdb-ci]

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 3b023b75e912b343c440a4675268764ce8632934
• Duration 0:17:16
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Logs (available for 30 days)
• Build Artifact (available for 30 days)