foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Published 20 hours ago • verified publisher icon apple

tuple: user defined type support

Open sfc-gh-dzhou opened this issue 3 years ago • 4 comments

While user defined codes are in the tuple documentation. Neither the c++ or the java tuple implementations allow for parsing the user defined codes.

This series makes the assumption that user defined codes are expected to be at the end of a tuple and consume the remainder. This is because no delimiter is defined for this user defined types. The area can be accessed as a string and users can use that accordingly.

Passes 100k correctness.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-dzhou avatar Sep 23 '22 01:09 sfc-gh-dzhou

Doxense CI Report for Windows 10

  • Commit ID: 350e3fa5d49414d72ad409004ce346b51a09ce9a
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 23 '22 02:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 350e3fa5d49414d72ad409004ce346b51a09ce9a
  • Duration 0:44:03
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 02:09 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 350e3fa5d49414d72ad409004ce346b51a09ce9a
  • Duration 0:49:07
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 02:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 350e3fa5d49414d72ad409004ce346b51a09ce9a
  • Duration 2:07:57
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 03:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 77ca09a95cb25686492ae9d0edafe9afbd8e6e5f
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 23 '22 18:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 77ca09a95cb25686492ae9d0edafe9afbd8e6e5f
  • Duration 0:47:02
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 18:09 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 77ca09a95cb25686492ae9d0edafe9afbd8e6e5f
  • Duration 0:51:27
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 18:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 77ca09a95cb25686492ae9d0edafe9afbd8e6e5f
  • Duration 2:07:51
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 19:09 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: f3161e7cc828d8003eb2cb9ae898a6372f70d3ac
  • Duration 0:49:36
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 19:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: f3161e7cc828d8003eb2cb9ae898a6372f70d3ac
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 23 '22 20:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f3161e7cc828d8003eb2cb9ae898a6372f70d3ac
  • Duration 1:07:12
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 20:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 563b0a34dfba7ed06631f8b75291419b6dd855fa
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 23 '22 20:09 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f3161e7cc828d8003eb2cb9ae898a6372f70d3ac
  • Duration 2:08:36
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 21:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 563b0a34dfba7ed06631f8b75291419b6dd855fa
  • Duration 0:53:27
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 21:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 563b0a34dfba7ed06631f8b75291419b6dd855fa
  • Duration 2:09:30
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 22:09 foundationdb-ci