foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Replace BgDDMountainChopper and BgDDValleyFiller with BgDDLoadRebalance and make DDQueue use txnProcessor

Open sfc-gh-xwang opened this issue 3 years ago • 11 comments

100k test pass.

  • Remove the highly repeated code in BgDDMountainChopper and BgDDValleyFiller
  • Also extract the code using Database cx and Transaction into the IDDTxnProcessor method.
  • Wrap some actors into DDQueue methods because once the MockGlobalState is merged we want to test the BgDDRebalance function in the future. The way we'll do that is to have a derived class that can return customized results for getSrcDestTeams, rebalanceReadLoad and rebalanceTeams without create DDTeamCollection.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-xwang avatar Sep 22 '22 03:09 sfc-gh-xwang

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: aaed0c8b7ed8f32a36d71e6b96e7ae14d3d889ff
  • Duration 0:04:54
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 03:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: aaed0c8b7ed8f32a36d71e6b96e7ae14d3d889ff
  • Duration 0:04:58
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 03:09 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: aaed0c8b7ed8f32a36d71e6b96e7ae14d3d889ff
  • Duration 0:05:30
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 03:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: aaed0c8b7ed8f32a36d71e6b96e7ae14d3d889ff
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 22 '22 03:09 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: e7a280ec03bbeb3afe78b7c26ab4dbeb9cca2e4f
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 22 '22 03:09 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: e7a280ec03bbeb3afe78b7c26ab4dbeb9cca2e4f
  • Duration 0:50:49
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 04:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: e7a280ec03bbeb3afe78b7c26ab4dbeb9cca2e4f
  • Duration 0:52:27
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 04:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: e7a280ec03bbeb3afe78b7c26ab4dbeb9cca2e4f
  • Duration 2:09:40
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 22 '22 05:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 11a6cba2c6a0c89723fabbbe69358e148fa8fcca
  • Duration 0:43:16
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 01:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 11a6cba2c6a0c89723fabbbe69358e148fa8fcca
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 23 '22 01:09 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 11a6cba2c6a0c89723fabbbe69358e148fa8fcca
  • Duration 2:10:22
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 02:09 foundationdb-ci