foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Port the DB methods calling in DDShardTracker through DDTxnProcessor interface

Open sfc-gh-xwang opened this issue 3 years ago • 3 comments

  • Port the DB methods calling in DDShardTracker through DDTxnProcessor interface
  • removing some unused Transaction object coming from the a past refactoring commit

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-xwang avatar Sep 19 '22 21:09 sfc-gh-xwang

Doxense CI Report for Windows 10

  • Commit ID: 08f4c064503cd74425e85f57c7368f815abccf06
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 19 '22 22:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 08f4c064503cd74425e85f57c7368f815abccf06
  • Duration 1:16:12
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 19 '22 23:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 08f4c064503cd74425e85f57c7368f815abccf06
  • Duration 2:46:29
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 20 '22 00:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 266a6917a4f08a8cb55eb11ec02050f194f7fa2c
  • Duration 0:05:18
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 22:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 266a6917a4f08a8cb55eb11ec02050f194f7fa2c
  • Duration 0:05:19
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 22:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 1194774d54ee4a919f24e46000cf723275dd92b4
  • Duration 0:53:39
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 23 '22 23:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 1194774d54ee4a919f24e46000cf723275dd92b4
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 24 '22 00:09 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 1194774d54ee4a919f24e46000cf723275dd92b4
  • Duration 2:11:28
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 24 '22 00:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 91d2757a51f551a413e5b34173126983ee982e3b
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 27 '22 19:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 91d2757a51f551a413e5b34173126983ee982e3b
  • Duration 0:53:55
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 27 '22 19:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 91d2757a51f551a413e5b34173126983ee982e3b
  • Duration 2:11:22
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 27 '22 20:09 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 83efe51cfc700bd4cf76c36fc2550aba43bea04d
  • Duration 0:17:30
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 27 '22 23:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 83efe51cfc700bd4cf76c36fc2550aba43bea04d
  • Duration 0:21:39
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 00:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 83efe51cfc700bd4cf76c36fc2550aba43bea04d
  • Duration 0:22:19
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 00:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 83efe51cfc700bd4cf76c36fc2550aba43bea04d
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 28 '22 00:09 fdb-windows-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: f2dea33d082f416cce012e5dd0fcc0e8002057da
  • Duration 0:18:04
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 01:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: f2dea33d082f416cce012e5dd0fcc0e8002057da
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 28 '22 01:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f2dea33d082f416cce012e5dd0fcc0e8002057da
  • Duration 0:50:04
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 02:09 foundationdb-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: f2dea33d082f416cce012e5dd0fcc0e8002057da
  • Duration 0:50:23
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 02:09 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 79573a13e4981ecd6ff2392bb8955a8dedfbc171
  • Duration 0:16:49
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 02:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 79573a13e4981ecd6ff2392bb8955a8dedfbc171
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 28 '22 02:09 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 79573a13e4981ecd6ff2392bb8955a8dedfbc171
  • Duration 0:49:41
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 02:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 79573a13e4981ecd6ff2392bb8955a8dedfbc171
  • Duration 0:57:33
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 03:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f2dea33d082f416cce012e5dd0fcc0e8002057da
  • Duration 2:04:38
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 03:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 79573a13e4981ecd6ff2392bb8955a8dedfbc171
  • Duration 2:05:05
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 28 '22 04:09 foundationdb-ci