foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Address MutationLogReaderCorrectness.toml simulation test failure

Open sbodagala opened this issue 3 years ago • 4 comments

Version vector specific: Propagate the latest commit version, as part of the read request, when reading from a storage server.

Test that found this issue: Enabling version vector, with BLOCKING_PEEK_TIMEOUT set to 1.0sec, on "release-7.1" branch. build_output/bin/fdbserver -r simulation --crash -f /root/src/foundationdb/tests/fast/MutationLogReaderCorrectness.toml -b on -s 152835360

Testing:

  • The above test succeeds with this change set.
  • Simulation tests: Compiler: gcc. With version vector disabled: 20220915-142128-sre-f782c15a9ee39fad (on a slightly older commit of "main", shows a failure in "SnapCycleRestart.txt" test, which also fails without this change set), 20220916-205304-sre-d8ee7dda93c78438 (in progress). With version vector enabled: 20220916-211259-sre-1eba9b0c52dadb96 (in progress).

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sbodagala avatar Sep 16 '22 21:09 sbodagala

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 89be8e0d4ec3964ab2e808adb3e108bd07666cae
  • Duration 0:47:43
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 22:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 89be8e0d4ec3964ab2e808adb3e108bd07666cae
  • Duration 1:07:12
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 22:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 89be8e0d4ec3964ab2e808adb3e108bd07666cae
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 16 '22 22:09 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 89be8e0d4ec3964ab2e808adb3e108bd07666cae
  • Duration 2:49:50
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 17 '22 00:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b50276ff5a54a9255ae77f6a1a1a9bfec33830d4
  • Duration 0:05:27
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 03 '22 21:10 foundationdb-ci

I think I messed up here. @jzhou77 / @dlambrig : Do you know of a way to get this diff from GitHub? Thanks!

sbodagala avatar Oct 03 '22 21:10 sbodagala

Ok, I found a way to get this diff. I will apply it over the latest "main" and open another PR. Thanks!

sbodagala avatar Oct 03 '22 21:10 sbodagala

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b50276ff5a54a9255ae77f6a1a1a9bfec33830d4
  • Duration 0:17:00
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Oct 03 '22 22:10 foundationdb-ci