foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Add `probe::assert::RocksDB` code probe annotation

Open sfc-gh-tclinkenbeard opened this issue 3 years ago • 6 comments

This adds an code probe annotation, to avoid reporting un-hit code probes when compiling with SSD_ROCKSDB_EXPERIMENTAL off.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-tclinkenbeard avatar Sep 15 '22 23:09 sfc-gh-tclinkenbeard

Doxense CI Report for Windows 10

  • Commit ID: b273ad83ff0bb53fa68012ca38085ecb0eff9749
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 15 '22 23:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b273ad83ff0bb53fa68012ca38085ecb0eff9749
  • Duration 0:45:55
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 00:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b273ad83ff0bb53fa68012ca38085ecb0eff9749
  • Duration 2:46:14
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 02:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: d30697eb606e3cf6bb0b2d043c86833225fdc2e5
  • Duration 0:44:13
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 19 '22 19:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: d30697eb606e3cf6bb0b2d043c86833225fdc2e5
  • Duration 2:45:01
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 19 '22 21:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: d30697eb606e3cf6bb0b2d043c86833225fdc2e5
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 19 '22 22:09 fdb-windows-ci

Doxense CI Report for Windows 10

  • Commit ID: c503b2dc53c1af3ab1f4bb8334aebae33515ef6a
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 26 '22 21:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c503b2dc53c1af3ab1f4bb8334aebae33515ef6a
  • Duration 1:02:54
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 26 '22 22:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c503b2dc53c1af3ab1f4bb8334aebae33515ef6a
  • Duration 2:45:46
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 26 '22 23:09 foundationdb-ci