foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Make exclusion less pessimistic when warning about low space usage

Open vishesh opened this issue 2 years ago • 22 comments

Tries to account for shared disks by looking at disk_id if available.

#8127

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

vishesh avatar Sep 14 '22 20:09 vishesh

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b3f4939299e505dc8d78251481f0f8454672c9a5
  • Duration 0:05:13
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b3f4939299e505dc8d78251481f0f8454672c9a5
  • Duration 0:05:12
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 827f3a1bdae4411831d1eb911dad91c989063ca9
  • Duration 0:04:33
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 827f3a1bdae4411831d1eb911dad91c989063ca9
  • Duration 0:04:32
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a624f84f25430afad49d1f3de6c9b86da6a8f755
  • Duration 0:04:57
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a624f84f25430afad49d1f3de6c9b86da6a8f755
  • Duration 0:04:59
  • Result: :x: FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 20:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 44c2adeee55bb1b7d408eb8ff16e66d288998559
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 14 '22 20:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 44c2adeee55bb1b7d408eb8ff16e66d288998559
  • Duration 0:07:05
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 21:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 44c2adeee55bb1b7d408eb8ff16e66d288998559
  • Duration 0:07:41
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 21:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 5260fde2108cfefaac14401607da42c71cb4ec8e
  • Duration 0:10:03
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version 5260fde2108cfefaac14401607da42c71cb4ec8e
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 21:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 5260fde2108cfefaac14401607da42c71cb4ec8e
  • Duration 0:10:06
  • Result: :x: FAILED
  • Error: reference not found for primary source and source version 5260fde2108cfefaac14401607da42c71cb4ec8e
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 21:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 379d798eb9f864c52508bf7539d734adac6ef4b3
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 14 '22 22:09 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 379d798eb9f864c52508bf7539d734adac6ef4b3
  • Duration 1:05:37
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 14 '22 22:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 379d798eb9f864c52508bf7539d734adac6ef4b3
  • Duration 2:47:11
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 15 '22 00:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 0060aa4d157d81c928bc912f315d558984cf1e86
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 16 '22 01:09 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 0060aa4d157d81c928bc912f315d558984cf1e86
  • Duration 0:47:46
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 02:09 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 0060aa4d157d81c928bc912f315d558984cf1e86
  • Duration 1:11:03
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 02:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 0060aa4d157d81c928bc912f315d558984cf1e86
  • Duration 2:45:09
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 16 '22 04:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: ddd3217471c260820cc50824371149847e248bc8
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 20 '22 18:09 fdb-windows-ci

@jzhou77 : Yes the test is here https://github.com/FoundationDB/fdb-kubernetes-tests/pull/660

vishesh avatar Sep 20 '22 19:09 vishesh

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: ddd3217471c260820cc50824371149847e248bc8
  • Duration 1:21:47
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 20 '22 19:09 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ddd3217471c260820cc50824371149847e248bc8
  • Duration 2:47:20
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 20 '22 20:09 foundationdb-ci