foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

mako should be in packages/bin

Open sfc-gh-sgwydir opened this issue 3 years ago • 3 comments

This change adds mako to the build/packages/bin directory with all the other binaries when running cpack, which is useful for automation.

As a side effect this adds mako to the foundationdb-clients packages. I'd like to get some feedback on whether or not this is desirable for other users or we should create a third package with tools, or just not package mako at all.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-sgwydir avatar Sep 12 '22 18:09 sfc-gh-sgwydir

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4c51445cd9a20570285ace9b004c91765c22bb00
  • Duration 1:12:00
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 12 '22 19:09 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 4c51445cd9a20570285ace9b004c91765c22bb00
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Sep 12 '22 19:09 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4c51445cd9a20570285ace9b004c91765c22bb00
  • Duration 2:46:15
  • Result: :x: FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Sep 12 '22 21:09 foundationdb-ci