foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Add restart test coverage from snowflake-specific binaries

Open sfc-gh-anoyes opened this issue 2 years ago • 3 comments

Add snowflake-specific directory of old binaries as candidates for old binaries in restart tests, if that directory exists.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-anoyes avatar Aug 11 '22 15:08 sfc-gh-anoyes

Doxense CI Report for Windows 10

  • Commit ID: efbe995fca2ead5097656c1d8ee5903a3ddd6112
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 11 '22 15:08 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: efbe995fca2ead5097656c1d8ee5903a3ddd6112
  • Duration 0:37:36
  • Result: :x: FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/foundationdb-base:${FDB_VERSION}-${COMMIT_SHA}-debug --file Dockerfile.eks --target foundationdb-base .. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 11 '22 16:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: efbe995fca2ead5097656c1d8ee5903a3ddd6112
  • Duration 0:58:19
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Aug 11 '22 16:08 foundationdb-ci

Should we call it customBinaries or something more generic, then accept an arbitrary path through a CMake parameter?

sfc-gh-kmakino avatar Aug 15 '22 16:08 sfc-gh-kmakino

@sfc-gh-kmakino I agree, we should make this more generic. However, we probably want to clean this up in the (soon to be posted) python re-implementation

sfc-gh-mpilman avatar Aug 15 '22 20:08 sfc-gh-mpilman

Doxense CI Report for Windows 10

  • Commit ID: 06de3830eda47dc5922949cc4fd856769a80a226
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Aug 18 '22 23:08 fdb-windows-ci

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: 06de3830eda47dc5922949cc4fd856769a80a226
  • Duration 0:35:04
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 23:08 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 06de3830eda47dc5922949cc4fd856769a80a226
  • Duration 0:36:37
  • Result: :x: FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/foundationdb-base:${FDB_VERSION}-${COMMIT_SHA}-debug --file Dockerfile.eks --target foundationdb-base .. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 23:08 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 06de3830eda47dc5922949cc4fd856769a80a226
  • Duration 0:53:58
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Aug 18 '22 23:08 foundationdb-ci