foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix ConflictingKeysImpl::getRange

Open sfc-gh-clin opened this issue 2 years ago • 9 comments

This pr is fixing the specific bug in conflicting keys implementation. Also add the random read tests for this implementation.

A more general test is pr #7597

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-clin avatar Jul 20 '22 17:07 sfc-gh-clin

Doxense CI Report for Windows 10

  • Commit ID: bdde648aea3622f9206fa00c1646e6f10581e00a
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 20 '22 17:07 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: bdde648aea3622f9206fa00c1646e6f10581e00a
  • Duration 0:44:46
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 20 '22 17:07 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 3deaba0673eb8100e07c6a3159c2270cd47ee05b
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 20 '22 18:07 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: bdde648aea3622f9206fa00c1646e6f10581e00a
  • Duration 2:33:07
  • Result: :x: FAILED
  • Error: Error while executing command: make -C tests -kj run. Reason: exit status 2
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 20 '22 19:07 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 3deaba0673eb8100e07c6a3159c2270cd47ee05b
  • Duration 1:13:35
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 20 '22 19:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 3deaba0673eb8100e07c6a3159c2270cd47ee05b
  • Duration 4:18:09
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 20 '22 22:07 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 53a065fa49129a440bea3232b6c639171402ca11
  • Duration 0:05:12
  • Result: :x: FAILED
  • Error: AccessDenied: Access Denied status code: 403, request id: 1Y32MKC92QNSN2D5, host id: SWJa4IW8kelh6VNCh55BniTuMt9u6TxQgwR2JpTjvWQGes6EastMvIBjahEtmPM2ssmnjc59MRs=
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 21 '22 17:07 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 53a065fa49129a440bea3232b6c639171402ca11
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 21 '22 17:07 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 53a065fa49129a440bea3232b6c639171402ca11
  • Duration 4:16:21
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 21 '22 21:07 foundationdb-ci

Closed as #7597 is merged

sfc-gh-clin avatar Aug 16 '22 18:08 sfc-gh-clin