foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Disable eager reads

Open yao-xiao-github opened this issue 3 years ago • 6 comments

20220712-200112-yaoxiao-3d2cc43e593c575c compressed=True data_size=34122997 duration=5267656 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:49:39 sanity=False started=100216 stopped=20220712-205051 submitted=20220712-200112 timeout=5400 username=yaoxiao

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

yao-xiao-github avatar Jul 12 '22 18:07 yao-xiao-github

Doxense CI Report for Windows 10

  • Commit ID: 706298135da851e2a09a033729a9da73e0adc254
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jul 12 '22 19:07 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 706298135da851e2a09a033729a9da73e0adc254
  • Duration 0:55:31
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 12 '22 19:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 706298135da851e2a09a033729a9da73e0adc254
  • Duration 4:16:44
  • Result: :x: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jul 12 '22 23:07 foundationdb-ci

What's the performance impact of this change?

jzhou77 avatar Jul 13 '22 04:07 jzhou77

What's the motivation for this change? Is this only for RocksDB? Can you describe more details, because for SQLite/Redwood engine, the change can cause performance problems (some pathology related to reads).

jzhou77 avatar Jul 18 '22 20:07 jzhou77

What's the motivation for this change? Is this only for RocksDB? Can you describe more details, because for SQLite/Redwood engine, the change can cause performance problems.

This change was added a while ago and aims to improve read performance by removing unnecessary reads. @neethuhaneesha Could you provide more information? Thanks!

yao-xiao-github avatar Jul 18 '22 20:07 yao-xiao-github