foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Added LatencySample for range read, and traces for slow range reads.

Open liquid-helium opened this issue 3 years ago • 5 comments

Added LatencySample for range read, and traces for slow range reads.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

liquid-helium avatar Jan 10 '22 21:01 liquid-helium

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: cbb38d4fdffc75597f61ced4229058734a70a163
  • Result: FAILED
  • Error: Error while executing command: cmake -S . -B build_output -D USE_CCACHE=ON -D USE_WERROR=ON -D RocksDB_ROOT=/opt/rocksdb-6.22.1 -D RUN_JUNIT_TESTS=ON -D RUN_JAVA_INTEGRATION_TESTS=ON -G Ninja. Reason: exit status 1
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jan 10 '22 21:01 foundationdb-ci

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: c3fc19cb009e1e5072590b679c88a5fadfd036ad
  • Result: FAILED
  • Error: reference not found for primary source and source version c3fc19cb009e1e5072590b679c88a5fadfd036ad
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jan 10 '22 21:01 foundationdb-ci

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: c3fc19cb009e1e5072590b679c88a5fadfd036ad
  • Result: FAILED
  • Error: reference not found for primary source and source version c3fc19cb009e1e5072590b679c88a5fadfd036ad
  • Build Logs (available for 30 days)

foundationdb-ci avatar Jan 10 '22 21:01 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: cbb38d4fdffc75597f61ced4229058734a70a163
  • Result: SUCCEEDED
  • Build Logs (available dor 30 days)

fdb-windows-ci avatar Jan 24 '22 22:01 fdb-windows-ci

https://github.com/apple/foundationdb/pull/8173 was just merged that adds a latency sample for range reads measured in the same way as the existing read latency sample. Does that supersede this?

sfc-gh-abeamon avatar Sep 19 '22 17:09 sfc-gh-abeamon

@liquid-helium, the other PR https://github.com/apple/foundationdb/pull/8173 also added the LatencySample. Maybe you can add your logic on top of that PR?

jzhou77 avatar Oct 03 '22 17:10 jzhou77