foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix advanceversion ctest and re-enable it

Open sfc-gh-clin opened this issue 3 years ago • 2 comments

It seems to be if we advanceversion to a much larger version (10000*current_version), the recovery will take longer to finish. The test used to be flaky as it continues to run while the database is sometimes unavailable after advanceversion is finished. Add a check in the test to make sure the recovery is finished before running next test.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-clin avatar Aug 06 '21 23:08 sfc-gh-clin

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 94fa100def82eadfe47a3703513a09071eb263be
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

foundationdb-ci avatar Aug 07 '21 00:08 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build-macos
  • Commit ID: 94fa100def82eadfe47a3703513a09071eb263be
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

foundationdb-ci avatar Aug 07 '21 00:08 foundationdb-ci