foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix fdbcli cache_range command

Open sfc-gh-clin opened this issue 3 years ago • 1 comments

The follow commands will fail

cache_range set a d
cache_range clear b c

will throw inverted_range error.

While debugging, it was found that the parameters used to call getRange were not correct. In particular, we want to set reverse=true but it applied as snapshot=true.

The inverted_range error was thrown in ApplyMetadataMutation.actor.cpp where we constructing begin keys and end keys.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-clin avatar Jul 01 '21 01:07 sfc-gh-clin

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: ddd4f058df845f00f1be27070fd4278e95916e8f
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar Jul 01 '21 01:07 foundationdb-ci