foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Unify peer address key in event traces

Open johscheuer opened this issue 4 years ago • 1 comments

I didn't find any matching issue (if that is somewhere else address please close this issue). I noticed that some event have the PeerAddress key and some others have PeerAddr. As far as I can tell these always reference the same value (e.g. the address of the peer). It would be nice to have the same key in all events to make it easier for an operator to search for events with a peer address. Personally I would prefer PeerAddress. In the transition phase the changed event should probably log both and then in the next release we can drop the deprecated key.

johscheuer avatar May 21 '21 13:05 johscheuer

TraceEvent has a specialization for address and we could add a specialization like .peerAddr().

jzhou77 avatar May 24 '21 20:05 jzhou77