foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix the crash when cluster commit version is largely advanced.

Open RenxuanW opened this issue 4 years ago • 10 comments

  1. When backup sees a large version gap, print a SevError and stop;
  2. If there are any active backup, prevent a restore.

20210509-023950-renxuan-b5a235b28d943b77 compressed=True data_size=23062715 duration=3728369 ended=101340 fail=1 fail_fast=10 max_runs=100000 pass=100400 priority=100 remaining=0 runtime=0:21:30 sanity=False started=101407 stopped=20210509-030120 submitted=20210509-023950 timeout=5400 username=renxuan

The failed test is fast/LowLatency.toml, unrelated.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

RenxuanW avatar May 09 '21 05:05 RenxuanW

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 0abf3c4ece352d735e38dac0952aa666cb391867
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 09 '21 06:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 203c4ff92e68638e33e4624507a521fd4fed378d
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 09 '21 18:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 718e689666b05406c4038793b4d5b6ca6dc7c14d
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 00:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: e5792a840552b2730e33bcc2692f9523ddaa76e6
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 04:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: d712061eca3c073b1662f602b8464e204f53e199
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 05:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 76b9d989f726d5462cfa763c01e95b1e94309da3
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 05:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: f7a95817ffa8fd0aafc1168344018da60cc0a08a
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 17:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 86c5e406a2527bfdd3514f8e27df4eebe8829966
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 17:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 6c4de447b707fd10f85c7a40987ab15f30639f0c
  • Result: FAILED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 18:05 foundationdb-ci

AWS CodeBuild CI Report

  • CodeBuild project: foundationdb-pull-request-build
  • Commit ID: 634eaf11c60e93152f468672393b74f5f4cb34eb
  • Result: SUCCEEDED
  • Build Logs (available for 7 days)

foundationdb-ci avatar May 10 '21 19:05 foundationdb-ci

@sfc-gh-ljoswiak is working on a fix for this problem, can you please link here?

jzhou77 avatar Oct 10 '22 16:10 jzhou77

#6743 is a WIP PR to fix the restore side. There will be a separate PR to fix backups as well.

sfc-gh-ljoswiak avatar Oct 10 '22 16:10 sfc-gh-ljoswiak