foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Published 20 hours ago • verified publisher icon apple

Remove native resource cleanup in Java finalizers

Open ajbeamon opened this issue 5 years ago • 3 comments

We deprecated the behavior of relying on Java finalizers for native resource cleanup a while ago in release 5.1. This PR now removes this behavior so that we don't have any custom finalizers.

ajbeamon avatar May 27 '20 18:05 ajbeamon

This is, strictly speaking, a breaking change? I of course agree one should not rely on Finalizers, and I think we do not, but I can't be 100% sure. So in case we do, this will be potentially a breaking change, right?

sfc-gh-gkliot avatar Mar 12 '21 23:03 sfc-gh-gkliot

Yes, this is a behavior change that would result in not having the finalizer available as a backstop anymore.

sfc-gh-abeamon avatar Mar 12 '21 23:03 sfc-gh-abeamon

@alecgrieser , can you take a look?

jzhou77 avatar Oct 31 '22 16:10 jzhou77