foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Improper use of onReadable in HTTPServer within fdbrpc

Open gc87 opened this issue 3 months ago • 0 comments

I see in the documentation for conn->onReadable() that a prior conn->read() which returns 0 is required before calling conn->onReadable(). Does this imply that the HTTP server implementation in fdbrpc is incorrect?

https://github.com/apple/foundationdb/blob/e1300053109c984b27070817792534725daea603/flow/include/flow/IConnection.h#L58-L60

There is no conn->read() call before conn->onReadable in the connectionHandler implementation.

https://github.com/apple/foundationdb/blob/e1300053109c984b27070817792534725daea603/fdbrpc/HTTPServer.actor.cpp#L89-L91

gc87 avatar Sep 29 '25 07:09 gc87