foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

WIP: Upgrade fmt from 8.1.1 to 11.0.2

Open sepeth opened this issue 1 year ago • 0 comments

And, added via cmake FetchContent, and removed contrib/fmt-8.1.1

Please don't merge this yet. Because I see CycleTest is failing when I run Simulation with tests/default.txt due to Rate below desired rate. I saw transactions metrics has dropped after this change (tested only on macOS). Apparently there was a performance regression with 11, but it says it got fixed with 11.0.2 and it seems unrelated (see 11.0.2 Release Notes).

I wanted to share this PR in case it is useful in the future and if someone has an idea.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sepeth avatar Aug 23 '24 19:08 sepeth