foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Update cli docs and perpetual storage wiggle docs

Open johscheuer opened this issue 1 year ago • 9 comments

Found some improvements for the docs when I worked on https://github.com/FoundationDB/fdb-kubernetes-operator/pull/2090.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [x] The PR has a description, explaining both the problem and the solution.
  • [x] The description mentions which forms of testing were done and the testing seems reasonable.
  • [x] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

johscheuer avatar Jul 01 '24 13:07 johscheuer

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 0:21:51
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 13:07 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 0:36:31
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 14:07 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 0:38:07
  • Result: :x: FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/base:${FDB_VERSION}-${COMMIT_SHA} --file Dockerfile --target base .. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Jul 01 '24 14:07 foundationdb-ci

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 0:47:25
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 14:07 foundationdb-ci

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 0:50:25
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 14:07 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 1:25:04
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 14:07 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f9ae34736d0c4f581afaee49f4135eb97721425e
  • Duration 1:33:23
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jul 01 '24 15:07 foundationdb-ci

@jzhou77 do we need to back-port those changes to 7.1/7.3? I'm not sure from which branch the docs are deployed.

The docs and the feature exists in both 7.1 and 7.3

neethuhaneesha avatar Jul 01 '24 16:07 neethuhaneesha

@jzhou77 do we need to back-port those changes to 7.1/7.3? I'm not sure from which branch the docs are deployed.

Yes, we need to backport to 7.1 and 7.3 branches. The documentation is generated from release branch, currently 7.1

jzhou77 avatar Jul 08 '24 05:07 jzhou77