foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

fix signed int and overflow bugs

Open flowguru opened this issue 1 year ago • 23 comments

page needs to have int instead of uint32_t, as we use -1 to indicate an invalid page.

timestamp needs to have 64 bits to maintain milliseconds precision.

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

flowguru avatar Feb 22 '24 19:02 flowguru

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 640d33a5ebe11690137af762634d90030018dc18
  • Duration 0:20:07
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 19:02 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:20:05
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 640d33a5ebe11690137af762634d90030018dc18
  • Duration 0:56:07
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 640d33a5ebe11690137af762634d90030018dc18
  • Duration 1:06:21
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:34:01
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 640d33a5ebe11690137af762634d90030018dc18
  • Duration 1:14:59
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

error seems unrelated, but there are quite a few of them, let me double check

flowguru avatar Feb 22 '24 20:02 flowguru

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:45:33
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 20:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:54:08
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Feb 22 '24 21:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 1:10:18
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 21:02 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 1:21:44
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 21:02 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:20:13
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 22:02 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:34:12
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 22:02 foundationdb-ci

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:45:17
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 22:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 0:54:34
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Feb 22 '24 22:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 1:02:50
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 22:02 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c517225803407076b12bff6b711af643f78bbdd7
  • Duration 1:13:44
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 22 '24 23:02 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 0:21:33
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 23 '24 02:02 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 0:33:45
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 23 '24 02:02 foundationdb-ci

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 0:45:25
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 23 '24 03:02 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 0:59:17
  • Result: :x: FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar Feb 23 '24 03:02 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 1:05:07
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 23 '24 03:02 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 98b6fe2c454608a3ef6ad6e13d9ff003bae9524f
  • Duration 1:15:00
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Feb 23 '24 03:02 foundationdb-ci

using https://github.com/apple/foundationdb/pull/11273 instead

flowguru avatar Apr 01 '24 21:04 flowguru