ConsistencyScanState is introduced as a KeyBackedClass which provides access and watchability to the consistency scan configuration and access to (improved) stats and execution state which does not interfere with control state.

The state is divided into sub-objects

Config - Tells the scan whether and how to run. Written by user, read by scan. Connected to the class's WatchableTrigger.
RangeConfig - KeyBackedRangeMap which tells the scan what ranges to operate on or ignore. Connected to the class's WatchableTrigger. This is defined but not used yet.
RoundStats - Stats and progress state for the a Round.
RoundStatsHistory - the last 90 days (by default) of RoundStats
LifetimeStats - a subset of Stats counts but for all time for the cluster

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

[ ] The PR has a description, explaining both the problem and the solution.
[ ] The description mentions which forms of testing were done and the testing seems reasonable.
[ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

[ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
[ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

May 02 '23 18:05 sfc-gh-satherton

Doxense CI Report for Windows 10

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Result: :x: FAILED
Build Logs (available for 30 days)

May 02 '23 19:05 fdb-windows-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Duration 0:13:21
Result: :x: FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Duration 0:15:22
Result: :x: FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Duration 0:15:48
Result: :x: FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Duration 0:17:47
Result: :x: FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 24f4c0378e9f06cecbfe5b97b6fbb8bc7d575710
Duration 0:17:57
Result: :x: FAILED
Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

May 02 '23 19:05 foundationdb-ci