coremltools icon indicating copy to clipboard operation
coremltools copied to clipboard

Fix immediate output getattr

Open tritolol opened this issue 6 months ago • 5 comments

Fixes #2538.

Changed remove_getattr_nodes() such that it adds a new constant op if it encounters a getattr op that is part of the graph's output. Before it raised an error wich caused some networks not to convert.

Added a unit test for the scenario.

tritolol avatar Jun 12 '25 06:06 tritolol

@tritolol thanks for the pull request. I apologize that no one seems to have looked at this. Please rebase this change on top of tip of main. Then I will kick off a CI run.

TobyRoseman avatar Jul 28 '25 20:07 TobyRoseman

@TobyRoseman I'm not sure if you are automatically notified, so just in case you are not: The rebase is done.

tritolol avatar Aug 11 '25 07:08 tritolol

Thanks @tritolol. CI: https://gitlab.com/coremltools1/coremltools/-/pipelines/1978748030

TobyRoseman avatar Aug 11 '25 23:08 TobyRoseman

@TobyRoseman are any of the failing tests related to this PR? There is no indication of that for me.

tritolol avatar Aug 15 '25 08:08 tritolol

@tritolol - I don't think those failures are related to this change. Please rebase this change on top the latest main.

TobyRoseman avatar Sep 08 '25 20:09 TobyRoseman