app-store-server-library-python icon indicating copy to clipboard operation
app-store-server-library-python copied to clipboard
verified publisher icon apple

feat: pydantic models

Open ahnsv opened this issue 2 years ago • 2 comments

Resolve #10

Hi, The test code gets messy to make the models (attr, pydantic) compatible. If it feels right, I want to merge them first, refactor them and apply more validation criteria on model fields in later PRs.

ahnsv avatar Sep 17 '23 14:09 ahnsv

@ahnsv A few high level questions:

  • Is your goal to have support for attr and pydantic both going forwards?
  • Is the V1 vs V2 model approach meant to be temporary or permanent?

alexanderjordanbaker avatar Sep 18 '23 16:09 alexanderjordanbaker

@alexanderjordanbaker I think it would be better if we can replace it. In this PR, I added v2 for compatibility. Do you think that I should make it replace it in this PR?

ahnsv avatar Sep 22 '23 12:09 ahnsv