app-store-server-library-python icon indicating copy to clipboard operation
app-store-server-library-python copied to clipboard

GitHub Dependabot links to the wrong app-store-server-library repo

Open WFT opened this issue 1 year ago • 3 comments

Hi, this is a bit of an odd one. I think it’s something you might be fix, but I’m really not sure where the misconfiguration is.

GitHub Dependabot links to the Swift repo instead of this one when it makes a PR on a repo that has the Python library as a dependency.

I’ve made a demo repo where you can see the issue here: https://github.com/WFT/demo-dependabot-app-store-lib-python/pull/2

Every link in that PR leads to the wrong repo.

The current 1.4.0 version of the Python library doesn’t exist in the Swift library, but when the same version number exists in both repos it will pull changelog items from the Swift repo too. This is problematic because the changelog items won’t correspond to what has actually changed in the Python library.

WFT avatar Sep 17 '24 20:09 WFT

Hello @WFT, not seen this before, will ask around

alexanderjordanbaker avatar Sep 18 '24 00:09 alexanderjordanbaker

@WFT Could you please open another reproducer, if possible, I've received word this may be fixed

alexanderjordanbaker avatar Sep 30 '24 16:09 alexanderjordanbaker

Thanks for working on this @alexanderjordanbaker ! I had dependabot rebase that PR a few times & it didn't seem to change anything so I created a new repo with same contents and got the same results: https://github.com/WFT/demo-dependabot-app-store-lib-python-2/pull/1

So it doesn't seem fixed

WFT avatar Sep 30 '24 17:09 WFT

Holding until confirming fix, need to have a release to update dependabot

alexanderjordanbaker avatar Feb 18 '25 17:02 alexanderjordanbaker

https://github.com/WFT/demo-dependabot-app-store-lib-python-2/pull/2

Latest release seems to work 🎉

Thanks!

WFT avatar Feb 18 '25 19:02 WFT