AudioUnitSDK icon indicating copy to clipboard operation
AudioUnitSDK copied to clipboard

Update Xcode Project and fix compiler warnings

Open AZero13 opened this issue 3 years ago • 4 comments

AZero13 avatar Nov 19 '22 16:11 AZero13

Thanks for the contribution. I've looked through and a few of the changes look sound and I have opened a PR internally to adopt them. There are several though that I don't see a reason or motivation for, and I will leave comments, to which perhaps you can provide justification?

sophiapoirier avatar Dec 03 '22 00:12 sophiapoirier

@sophiapoirier I addressed all the issues!

AZero13 avatar Dec 11 '22 16:12 AZero13

@sophiapoirier I addressed all the issues!

Perhaps I could have been more clear in my initial comment about adopting some of these changes internally, and hopefully you didn't lose too much time making further edits, but to be more explicit: we do not merge PRs from here. We manage the project internally and only publish to the public here. So a pull request here is more like a feedback inbox.

sophiapoirier avatar Dec 14 '22 21:12 sophiapoirier

Some of this has been incorporated in AudioUnitSDK-1.2.0 released today. Thank you again for your contributions.

sophiapoirier avatar Oct 31 '23 22:10 sophiapoirier