java-client icon indicating copy to clipboard operation
java-client copied to clipboard

test: Verified disabled tests working and enabled them

Open sceiler opened this issue 2 years ago • 3 comments

  • Enable Android tests that were disabled and verified them working locally on Emulator 28
  • Rename AndroidConnectionTest methods to have more descriptive names and disable the ones relying on #17422
  • Refactor tests to work

Change list

Enabling Android tests and made slight changes where applicable to make tests run successfully.

Types of changes

What types of changes are you proposing/introducing to Java client? Put an x in the boxes that apply

  • [ ] No changes in production code.
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

As part of the Open Source Test Automation Summit we went through disabled Android tests and verified that disabled tests work on a local Emulator with the same API level as used by the CI/CD server. The tests where then enabled and failing ones were fixed and/or got a comment that indicates that enabling them would depend on an issue getting fixed first.

sceiler avatar Aug 27 '22 12:08 sceiler

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: sceiler / name: sceiler (8f5bbd0d696255d4b66f8eb445ce20f73bd3c0ae)

It looks like some tests still need tuning for the CI.

mykola-mokhnach avatar Aug 28 '22 06:08 mykola-mokhnach

Yep I'm going through it asap. The pullFile test fails for example because that file doesn't exist on the Emulator. Probably less flaky if we create the file on the Emulator and then pull it instead of assuming that that file already exist.

sceiler avatar Aug 28 '22 14:08 sceiler