dotnet-client icon indicating copy to clipboard operation
dotnet-client copied to clipboard

Implementing ICommandExecutor's ExecuteAsync() and using it in Execute()

Open kelmelzer opened this issue 1 year ago • 2 comments

I think this should fix it in Selenium 4.22+, but its untested so far of course. :)

List of changes

Implemented ICommandExecutor's ExecuteAsync(). Moved Execute() code to there and call it from Execute() with Task.Run()

Types of changes

What types of changes are you proposing/introducing to the .NET client? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] New feature (non-breaking change which adds value to the project)
  • [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Documentation

  • [ ] Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • [ ] Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

kelmelzer avatar Jul 02 '24 17:07 kelmelzer

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

Dor-bl avatar Jul 02 '24 17:07 Dor-bl

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

Sure thing. I did that by hand but will fork it and actually build it on my personal machine shortly :)

kelmelzer avatar Jul 08 '24 19:07 kelmelzer

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

Sure thing. I did that by hand but will fork it and actually build it on my personal machine shortly :)

This will not work for you because the Selenium team needs to fix the encapsulation they broke on internal Response Execute. So it would be best if you waited for the next release.

Dor-bl avatar Jul 08 '24 19:07 Dor-bl

Closing pull request. I made a new one which fixes the build and wraps ExecuteAsync() properly

kelmelzer avatar Jul 08 '24 20:07 kelmelzer