appium
[Feat]: replace non-w3c commands with mobile:, and add deprecation message if needed
Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
See https://github.com/appium/java-client/pull/1883
We're going to move non-w3c endpoint call to mobile (macos for mac2 driver etc) command, eventually, in the server side. Clients also want to follow the way.
Describe the solution you'd like A clear and concise description of what you want to happen.
- Remove non-w3c endpoint call, instead calls mobile extension command properly
- Mark non-w3c endpoint call as deprecate
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.
@KazuCocoa has a mobile extension been created for every non-w3c command? Or just the app management endpoints?
Maybe already exists: e.g. https://github.com/appium/appium-uiautomator2-driver
Potentially some are not, then we should add them in the server side
@laolubenson are you taking this? or should I add it to my TO-DO?
@Dor-bl I'll pick this up.
@KazuCocoa, do you mean deprecating this region at first? https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium/AppiumDriverCommand.cs#L19C53-L19C53
@KazuCocoa, do you mean deprecating this region at first? https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium/AppiumDriverCommand.cs#L19C53-L19C53
@KazuCocoa, do you have any input here?
yea, it looks correct. Perhaps not all commands already have mobile:, or still need to keep the command, but basically yes.
At least the file's commands will be via mobile: eventually or can simply drop as it no longer works. Some could keep as current deprecation comments for now as dotnet client v5, and can drop them as client v6 later.
@Dor-bl @KazuCocoa
Can I change the mobile prefix of the commands in AppiumDriverCommand based on appium/java-client#1883 and https://github.com/appium/appium-uiautomator2-driver?
Can I change the mobile prefix of the commands in AppiumDriverCommand based on appium/java-client#1883 and https://github.com/appium/appium-uiautomator2-driver?
@namilkimfree It's not that simple since the commands fromAppiumDriverCommand are also been used on xcuitest driver.
It will require a more clinical approach.
I suggest you start with one command at a time while making sure nothing breaks in the process.