appium-inspector icon indicating copy to clipboard operation
appium-inspector copied to clipboard

feat: call mobile command for ios page source

Open KazuCocoa opened this issue 3 years ago • 3 comments

at least this helps to reduce iOS's execution time. (but I know it drops visible attribute, so this is a kind of trade-off.) It's probably good to add a checkbox preference.

KazuCocoa avatar Feb 11 '22 07:02 KazuCocoa

I'd also say it makes sense to make this option configurable (and disabled by default as it would break the backward compatibility)

mykola-mokhnach avatar Feb 11 '22 08:02 mykola-mokhnach

yea. it makes sense. let me create a checkbox now as this pr. Then, i'm thinking to add something input text place so that users can specify excluding items (default is visible)

KazuCocoa avatar Feb 11 '22 18:02 KazuCocoa

yeah I like this idea. Not sure where a checkbox would go. I don't want to clutter up the UI too much. But let's see if you have an idea.

jlipps avatar Feb 11 '22 19:02 jlipps

Probably... we should keep /source and create a new settings api's item to exclude some attribute if needed as inspector's concept. let me close this pr

KazuCocoa avatar Nov 05 '22 06:11 KazuCocoa

need to re-construct this idea, but I'd love to keep considering how to change the "mode" of calling mobile:source instead of /source endpoint for iOS

KazuCocoa avatar Aug 23 '23 23:08 KazuCocoa

what about a sourceOptions setting which has values that are the same as parameters to mobile: source. If the sourceOptions setting is set, then mobile: source will be called instead of the default getPageSource behaviour whenever the user does call getPageSource

jlipps avatar Aug 24 '23 17:08 jlipps

-> https://github.com/appium/appium-inspector/issues/1062

KazuCocoa avatar Aug 26 '23 18:08 KazuCocoa