ae_page_objects icon indicating copy to clipboard operation
ae_page_objects copied to clipboard

Published 20 hours ago • verified publisher icon appfolio

AePageObjects::Collection specifies 'exact: true' when query

Open JingyuZ opened this issue 9 years ago • 2 comments

We didn't specify exact: true at any other places except for Collection class. For all the others they just use the default value for Capybara setting, which is false. https://github.com/appfolio/ae_page_objects/blob/master/lib/ae_page_objects/elements/collection.rb#L71

We are not sure why Collection is the exceptional one that has to specify exact: true. Any reasons behind it? If not, could we remove it and use the default value?

JingyuZ avatar Sep 15 '16 00:09 JingyuZ

Hi @JingyuZ Does this cause problem in running test? could you give more context?

ipmsteven avatar Sep 15 '16 03:09 ipmsteven

I created the issue not because I want to remove exact: true from collection right now, it’s more like a question for Donnie why we are only being strict with collections, why don't we set exact: true in Capybara settings and make everything strict?

JingyuZ avatar Sep 15 '16 16:09 JingyuZ