analytics-google icon indicating copy to clipboard operation
analytics-google copied to clipboard

Published 20 hours ago • verified publisher icon appfeel

Update iOS library to latest version 3.15 and optout method (iOS)

Open YannickGagnon opened this issue 9 years ago • 4 comments

YannickGagnon avatar Jan 22 '16 19:01 YannickGagnon

I only implemented the output for iOS, but I'm assuming it would be quite easy to set it up for Android.

YannickGagnon avatar Jan 22 '16 19:01 YannickGagnon

@YannickGagnon shouldn't it be updated https://github.com/appfeel/analytics-google/blob/master/plugin.xml#L66 as well?

miqmago avatar May 25 '16 15:05 miqmago

@miqmago, updated how? The file itself is updated but the reference isn't, unless I'm missing something

YannickGagnon avatar May 25 '16 18:05 YannickGagnon

Oh no, it's ok, my fault as I haven't seen that it was already updated the library file itself...

The problem I see with this PR is that you introduced a new method optOut in ios which has no equivalent in android, which will make a plugin error response in android platforms... Will you implement it in android as well?

miqmago avatar May 25 '16 22:05 miqmago