reactivesearch icon indicating copy to clipboard operation
reactivesearch copied to clipboard

ReferenceError: AbortController is not defined in 3.45.0 because of recent changes

Open arpithparikh opened this issue 2 years ago • 5 comments

Affected Projects React

Library Version: x.y.z

3.45.0

Describe the bug

I started getting errors in my live project for version 3.45.0 because of recent fixes. ReferenceError: AbortController is not defined node_modules/@appbaseio/reactivesearch/node_modules/appbase-js/dist/appbase-js.cjs.js (456:26)

Kindly please fix it or "appbase-js": "^5.3.4" to 5.0.1

This is the error!!!!!! var controller = new AbortController(); var signal = controller.signal;

To Reproduce Steps to reproduce the behavior: Run the project using 3.45.0

node version v14.16.1 6.14.12

arpithparikh avatar Aug 20 '23 23:08 arpithparikh

cc @siddharthlatest - Please review asap.

Have found a workaround for this. https://www.npmjs.com/package/node-abort-controller

Please add node version v14.16.1 compatibility for app base 3.45.0

arpithparikh avatar Aug 21 '23 01:08 arpithparikh

@arpithparikh It seems Node 14.17.3 (LTS) may support this and still work despite being EOL'ed earlier this year. I would recommend considering to upgrade to a supported version, or v3 (before 3.45.0 release) should work well in this case.

siddharthlatest avatar Aug 21 '23 02:08 siddharthlatest

Hi @siddharthlatest - I tried before the 3.45.0 release but it didn't work

arpithparikh avatar Aug 21 '23 03:08 arpithparikh

@arpithparikh I would suggest using 3.43.10 and you can share the stack trace if you're seeing an error. Abort controller isn't present in this release.

siddharthlatest avatar Aug 21 '23 05:08 siddharthlatest

@siddharthlatest - can you please list down the difference between 3.45.0 and 3.43.10? We can't simply change to a backward version. Also, I would suggest only putting new fixes for new versions.

arpithparikh avatar Aug 21 '23 17:08 arpithparikh