reactivesearch icon indicating copy to clipboard operation
reactivesearch copied to clipboard

Button instead of anchor

Open royduin opened this issue 4 years ago • 2 comments

As anchors do have/support a disabled attribute and they don't have a href so it doesn't make much sense to use anchors over buttons.

royduin avatar Apr 01 '21 10:04 royduin

I'm a little busy but I'm coming back on this soon!

royduin avatar Apr 20 '21 08:04 royduin

image

Nothing changes and everything just works as with anchors but with real support for the disabled attribute. Running into issues with anchors as the CSS selector a:disabled doesn't work as anchors do not have a disabled attribute. button:disabled works beacuse buttons really support disabled. And why use an anchor when there is no href?

Is it a breaking change? If anyone styles the pagination by element like a { ... } it's breaking, otherwise not.

royduin avatar May 25 '21 08:05 royduin