reactivesearch icon indicating copy to clipboard operation
reactivesearch copied to clipboard

fixes korean typing

Open littlehome-eugene opened this issue 5 years ago • 1 comments

Before submitting a pull request, please make sure the following is done:

screenshot was from dejavu

Before fix

broken

after fix

fixed

  • [ x] Describe the proposed changes and how it'll improve the library experience. as shown with the gif, currently, it's hard to type korean (i guess other languages too which requires several keystroke to make up a character) The pull requests fixes it.
  • [ x] Please make sure that there is no linting errors in the code. I just deleted a line which I believe has no effect on other functionality, there could be no linting errors
  • [x ] Create a PR to add/update the docs (if needed) at here. no docs required
  • [x ] Create a PR to add/update the storybook (if needed) at here.

Learn more about contributing: Contributing guides

let me know if I need to fix any

littlehome-eugene avatar Apr 20 '20 12:04 littlehome-eugene

let me know what label fails means :(

littlehome-eugene avatar Apr 23 '20 10:04 littlehome-eugene