reactivesearch icon indicating copy to clipboard operation
reactivesearch copied to clipboard

Deal with Internationalization whenever possible

Open e-gaulue opened this issue 5 years ago • 4 comments

Affected Projects React

Describe the solution you'd like have Strings in object's props

In pagination: "Prev", "Next" In ReactiveList: "results found in"

e-gaulue avatar Jan 20 '20 13:01 e-gaulue

Hey @e-gaulue

You can always use render props for creating custom pagination and result stats.

jyash97 avatar Jan 20 '20 14:01 jyash97

Hello @jyash97,

Of course, you can do it if you are in hurry. You just have to identify the source code, then copy/paste. For pagination, it's about 100 lines just to change 2 words. And for every new version, you need to check this piece of code has not changed...

But for the long term and to encourage this library adoption, it can't be the solution. Those strings could just be added to props with default values.

Regards,

e-gaulue avatar Jan 21 '20 12:01 e-gaulue

True

I agree. We are missing this at few places and once we identify all the places we can create a prop. For result stats, it's easy to do using renderResultStats. For pagination, we may need to introduce props that allow easy configuration.

Here is the issue that we can keep for tracking and mentioning static text: #173

jyash97 avatar Jan 22 '20 06:01 jyash97

Hi. So at this moment, what would be the simplest way to replace "Prev" with another string? It is a bit important for people like me who is developing things where 90% of population don't know what Prev means. In my case, replacing Prev (and Next) with some arrow symbols (← or ◀ ) might work. I checked the doc (https://opensource.appbase.io/reactive-manual/result-components/reactivelist.html) and probably will be able to make it, but I wonder what you would recommend.

toshimo avatar May 30 '20 07:05 toshimo