Martin Atkins

Results 1242 comments of Martin Atkins

Hi @wata727! Thanks for sharing this proposal. A common challenge with providing this kind of functionality against the JSON syntax is that the JSON syntax is always ambiguous until the...

Hi @notnoop, What you implemented here seems technically correct but I find myself curious as to why this would be necessary. In what situation would you have a pointer to...

Hi @acrewdson, For the moment `hclwrite.Format` (the basis of `terraform fmt`) is mainly focused on changes to horizontal whitespace: indenting, aligning, etc. The way it's currently built is optimized for...

I had a quick look at this myself today as part of some other work, and remembered why this is more complex than it first appears: the formatter is currently...

Hi @rifelpet, Unfortunately right now the `hclwrite` functionality is focused mainly on the simple sorts of cases that tend to arise when we're serializing static data into HCL using the...

Hi @calvin2021y, This requirement is necessary to support the otherwise-ambiguous JSON syntax for HCL. In that syntax the schemas you provide influence how HCL will interpret the JSON constructs in...

@calvin2021y if you have a specific proposal then I'd love to review it! The key design constraints would be: * Must be backward compatible with all existing input written in...

Hi @azr! Give how central this mechanism is in the API here I don't think we can really break it now. If we are to move forward with this I...

Hi @ryancragun! Thanks for tracking these down. For `nilToken` I can see clearly where the issue is: it's trying to share the `nilToken` object between multiple other objects but then...

Hi @ryancragun, I don't think it makes a huge amount of difference in practice, so I think what you did here is fine too... I was just focused on trying...