angularjs-viewhead icon indicating copy to clipboard operation
angularjs-viewhead copied to clipboard

Make sure we only remove view title from the directive that set it

Open vstene opened this issue 10 years ago • 1 comments

When doing a page change in ui-router, the scope.on('$destroy') is called after the new view title directive has been initialized, resulting that there is no view title present.

vstene avatar Feb 15 '16 10:02 vstene

Thanks for this! It's a great improvement to the robustness of the title handling.

I just had a design-ish question inline. If you don't have time to work on this further then no worries... just thinking about what is the best way to represent this internal state.

apparentlymart avatar Feb 19 '16 07:02 apparentlymart