detekt-rules-compose

detekt-rules-compose copied to clipboard

False positive on `ModifierParameterPosition` and `ComposableParametersOrdering`

6

``` @Composable fun MyComposable( modifier: Modifier = Modifier, content: LazyListScope.() -> Unit ) = LazyColumn(modifier = modifier, content = content) ``` `ModifierParameterPosition` and `ComposableParametersOrdering` raise an issue. The `content` parameter...

AfigAliyev

```kotlin @ExperimentalAnimationGraphicsApi @ExperimentalCoilApi @ExperimentalComposeUiApi @Composable fun ProductView( product: Product, modifier: Modifier = Modifier, //unused ) { val ... Card( modifier = Modifier .fillMaxWidth() ```

Drjacky

Extend `UnnecessaryEventHandlerParameter` for constants

4

I think that code like this should be also flagged: ```kotlin @Composable private fun Foo( onSomething: (Int) -> Unit, ) { Button(onClick = { onSomething(5) }) { /*...*/ } }...

BraisGabin

False positive on `UnnecessaryEventHandlerParameter`

4

Given this code: ```kotlin internal sealed class State { object Loading : State() data class Data(val id: String) : State() } @Composable internal fun MyButton( state: State, onClick: (String) ->...

BraisGabin

Compose ReusedModifierInstance false positive

4

## Expected Behavior I have a @Composable that receives a modifier, and the first child is ProvideWindowInsets that has no modifier parameter, and I put the received modifier on the...

raul19

False positive on ComposableFunctionName when using single expression functions

3

I get a false positive on this rule when using the following syntax: ```kotlin // Part of theme file @Composable fun AppTheme(content: @Composable () -> Unit) { // Theme setup...

patrickhoette

ModifierHeightWithText should not apply when Modifier.height(Intrinsic.Min)

1

If you specify Modifier.height(Intrinsic.Min) then this rule should not apply, because you allow the views to be drawn out fully and then wrap the content. This is useful when you...

sadikali

This code reports `ConditionCouldBeLifted` while it shouldn't: technically it's legal to have pager with an "empty" page. ```kotlin HorizontalPager(...) { pageIndex -> val branchEntry = entries.elementAtOrNull(pageIndex) if (branchEntry != null)...

dimsuz

False positive on `ReusedModifierInstance` when shadowing modifier

1

1.3.0 fixed a lot a false positives of `ReusedModifierInstance`. But there is one that it wasn't fixed yet. I created a test case to make it easy to reproduce it:...

BraisGabin

`TopLevelComposableFunctions` and `inteface`s

2

I like the idea of `TopLevelComposableFunctions`. The composable function shouldn't be declared inside an `Activity` or anything like that. But some times I have a Module were I want to...

BraisGabin