Migrate to GitHub Actions.

[simi]

Hello, I'm trying to upgrade gem to get stable CI. I have updated tests to be Ruby agnostic and I have migrated to GitHub Actions. I have included only supported Rubies for now to CI.

CI can be seen in action at https://github.com/RubyElders/declarative/pull/1. Not sure why it doesn't start in here. Maybe needs to enable first. Happy to help setting up this. This gem was identified as one of the crucial for whole RubyGems.org ecosystem and would be nice to get stable CI setup.

PS: I understand this gem is not developed anymore and I'll do my best to update popular reverse dependencies to remove the need of this gem. But meanwhile, it will be appreciated to at least test current version on CI to ensure it works with current Rubies.

[simi]

@apotonick friendly ping, new CI setup is one merge away :)

[simi]

@apotonick do you think there will be time to take a look? All changes in tests are 1:1, just testing the structure, not textual representation (which vary across Rubies).

[apotonick]

Hi @simi, thanks again! Could you rebase your PR and just add the CI setup? We have a utility method in trailblazer-core-utils that I will use the get the tests running (even though I'm absolutely not motivated to touch this gem :joy:): https://github.com/trailblazer/trailblazer-core-utils/blob/master/test/hash_inspect_test.rb#L6

[simi]

@apotonick I swear this is the last PR from my side. I'll work on disconnecting uber + declarative from active usage after. :) I'm happy to migrate tests to that util also. Should I copy it here or make those utils dev dependency?

[apotonick]

Haha, you can send as many PRs as you want :joy: We have the core-utils gem as a dev dependency in all TRB gems.

Which gem are you thinking about liberating from uber?

[simi]

@apotonick my current chain of fear is google-apis-core -> representable -> uber and declarative (did similar PR in there https://github.com/trailblazer/representable/pull/270). Representable is deeply rooted in google-apis-core, that one probably needs to keep maintained somehow. Would see how simple it would be to cut or inline other unmaintained representable deps.

[apotonick]

Ah, ok, we can make representable look maintained. Problem is, we're not the Rails core team and have 35 kids eager to help (yet, hahaha) but I see the pressure here and can allocate a few days the next week.

[simi]

Ah, ok, we can make representable look maintained. Problem is, we're not the Rails core team and have 35 kids eager to help (yet, hahaha) but I see the pressure here and can allocate a few days the next week.

I'm happy to jump there also. Nothing huge is needed, just ensure gem has stable CI and it passes no modern Rubies. Also quick check on issues there is nothing serious reported. I can contribute all this if anyone is around to review and merge :wink:.

[apotonick]

So... if I am deceiving and seducing, I can slowly lure you into TRB core....

[simi]

Is TRB still active thing?

[apotonick]

What makes you think it's not? It's just that we haven't had "big" releases, but the new upcoming stuff will blow your mind!

[simi]

@apotonick the mentioned helper blew my mind, it doesn't support all usecases like nested hashes. See example:

# original
_(schema.get("id").inspect).must_equal '#<Declarative::Definitions::Definition: @options={:name=>"id"}>'
# passing with helper, see options had to be changed anyway
_(Trailblazer::Core::Utils.inspect(schema.get("id"))).must_equal '#<Declarative::Definitions::Definition: @options={name: "id"}>'

Wouldn't be possible to merge this version where no helper is needed actually? Or do you need to support ancient Rubies?

---

PS: To answer your original question. I was clicking around, got to the https://trailblazer.to/2.1/pro#future-insights page with interesting future insight. 😸

[apotonick]

@simi We try to support older Rubies as Trailblazer and all its gems are focusing on refactoring, we had a bunch of users who were really grateful they could use our stuff to upgrade to newer Ruby. I will update the helper.

Yes, the TRB page is new, but some pages are still waiting to be "released" - coming soon. <insert construction worker animated GIF here, saying "this page is still under construction">

[apotonick]

Could you remove the changed tests from your PR and only give me the updated CI, please?

[simi]

@apotonick done

[apotonick]

Thanks! :green_heart: let's see what CI says.

[simi]

@apotonick thanks a lot for your time and patience, ping me if there's anything I can help :handshake:

[apotonick]

Next move: removing uber from representable?

[simi]

Next move: removing uber from representable?

If you agree on, I can try.

[apotonick]

It will be a bit tricky as we should replace it with trailblazer-option, feel free to give it a go, I will play with it, too!