thunderhub icon indicating copy to clipboard operation
thunderhub copied to clipboard

Probably wrong dependencies

Open doitwithnotepad opened this issue 5 months ago • 0 comments

Describe the problem/bug if you install thunderhub for production it does not install the dependencies correctly, because one of them is as development dep.

Your environment

  • Version of ThunderHub: 0.13.31
  • Deployment method: source
  • Other relevant environment details: Alpinelinux 3.20.2 | node v21.7.3 | npm 10.8.0

To Reproduce Steps to reproduce the behavior:

  1. cd /tmp
  2. git clone --branch v0.13.31 https://github.com/apotdevin/thunderhub.git && cd thunderhub
  3. npm install --omit=dev --omit=optional
  4. See error

Expected behavior install runtime dependencies

Actual behavior this:

> [email protected] prepare
> husky install

sh: husky: not found
npm error code 127
npm error path /tmp/thunderhub
npm error command failed
npm error command sh -c husky install
npm error A complete log of this run can be found in: /tmp/thunderhub/npm-cache/_logs/2024-09-02T15_26_46_984Z-debug-0.log

Screenshots/Links not applicable

Additional context possible solution: package.json

 [...]
   "dependencies": {
 [...]
+    "husky": "^8.0.3",
 [...]
   "devDependencies": {
 [...]
-    "husky": "^8.0.3",
 [...]

also i can bypass this issue with step 3 replaced by: npm install husky --omit=dev --omit=optional

doitwithnotepad avatar Sep 02 '24 15:09 doitwithnotepad