thunderhub
thunderhub copied to clipboard
apotdevin
Transactions screen/card consistently blows up for some deployments
This screen occurs when either navigating to /transactions or when the AJAX request that loads the transactions card comes back. I have opened the console to show the error, however I can't seem to replicate it outside of the environment that I'm in, nor can I figure out how to build it in a way that doesn't minify the js so I can see the real call stack. Additionally it seems this problem was introduced between 0.12.20 and 0.12.21. It does not seem to occur if there are no transactions in the transaction card, and it doesn't even always occur if there are some, though I haven't been able to find a pattern to when it works if there are transactions. But there are at least two deployments that consistently show this behavior. I have tested this against both Firefox and Tor and have managed to get it to exhibit this behavior.
Environment:
- node16
- alpine3.11
- Docker
- arm32v7
- Raspberry Pi 4
^ I'm not sure how relevant this is since this is a "client side exception" but since the client side exception happens because of a null object trying to have its keys enumerated it is possible the "true problem" is upstream and that the environment has something to do with it.
Things I've tried:
- Revert ln-service dependency back to the one in 0.12.20 (blows up)
- Deploy 0.12.21 on amd64, node16, LND 0.12.1 (works, even with transaction history)
- Deploy 0.12.21 on arm32v7, LND 0.12.1 (works only if there is no transaction history)
Please try and replicate this behavior because I am at a total loss as to what is happening here and I've tried everything I can to ascertain what is going on, to build the container I am using use this repo:
https://github.com/Start9Labs/thunderhub-wrapper
and make the project.
The build artifact called image.tar is the container in question.
OK after spending my day bisecting the commits I've narrowed it down to 6c0c84c9608d99d8028b72b889beca899ad8d3a4
And considering that it is only the transactions page/card the place to look is probably here: https://github.com/apotdevin/thunderhub/commit/6c0c84c9608d99d8028b72b889beca899ad8d3a4#diff-6084657410155bc8733e3cea0d88314614a92ace8960a793233bdd7f809a7bc2
This is where I'm out of my depth. But So far I've only managed to make it happen on arm32v7 so I'd strongly advise you build that and try and repro.
any chance someone familiar with the dependencies was able to look at this, I managed to narrow it down to a single commit that introduced the problem so it shouldn't take long to take a look.
We are moving away from armv7 so I haven't made the time to test, but if you don't officially support armv7 maybe the correct thing to do here is to remove the armv7 dockerfile from the repository.