Delete from trash leaves live page alone

[fredrikekelund]

Following up on the work in #206, I noticed recently that if you enable the deleteFromTrash option in apostrophe-pages and subsequently delete a draft page, the live document is left unaffected. I'm not sure what exactly would be the most wise course of action to solve this, but my original expectation was for both the draft and live document to be deleted altogether when I clicked "Delete from trash". Would it be viable to update the module to behave like that?

[boutell]

Good point, removing a document completely is never a wise move in the presence of workflow unless all documents sharing the same workflowGuid are removed. Across all locales, in fact.

The sensible course would be to do that, behind a confirmation prompt of considerable severity.

[fredrikekelund]

Hmm, are there any particular risks when completely removing a document if apostrophe-workflow is in use?

[boutell]

If you don't remove it from all locales, yes. If you do, no (I mean, it obviously bypasses the workflow approval process, but only sitewide admins can do it, and only if they enable the feature). It's a bug for a document to not exist in 100% of locales in the current architecture of workflow, although it can be trash and the trash is grouped conveniently in the UI to make this not a big problem visually.

On Mon, Nov 12, 2018 at 9:59 AM Fredrik Ekelund [email protected] wrote:

Hmm, are there any particular risks when completely removing a document if apostrophe-workflow is in use?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-workflow/issues/213#issuecomment-437911908, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fZC22m5voBUcmZuSTnW0Z_pxdOWjks5uuYzAgaJpZM4YZaie .

--

Thomas Boutell, Chief Software Architect P'unk Avenue | (215) 755-1330 | punkave.com