vscode-graphql icon indicating copy to clipboard operation
vscode-graphql copied to clipboard

add json schemas for apollo-router.yaml and supergraph.yaml

Open phryneas opened this issue 1 year ago • 4 comments

Following up on our discussion from last week.

phryneas avatar Sep 20 '24 15:09 phryneas

You can download the latest build of the extension for this PR here: vscode-apollo-0.0.0-build-1729249832.pr-216.commit-f344a9b.zip.

To install the extension, download the file, unzip it and install it in VS Code by selecting "Install from VSIX..." in the Extensions view.

Alternatively, run

code --install-extension vscode-apollo-0.0.0-build-1729249832.pr-216.commit-f344a9b.vsix --force

from the command line.

For older builds, please see the edit history of this comment.

github-actions[bot] avatar Sep 20 '24 15:09 github-actions[bot]

Something I didn't consider, that we should test, is how this works with unstable router features. We have new config for Router 2.0, I wonder if that shows up as an error, with this change 😐

dylan-apollo avatar Sep 20 '24 15:09 dylan-apollo

Something I didn't consider, that we should test, is how this works with unstable router features. We have new config for Router 2.0, I wonder if that shows up as an error, with this change 😐

Two strategies come to mind:

  • Have some "config-version" key in there and both versions in the schema as alternative schemas (maybe this could even reference two different urls? I'm not that deep in json schemas yet)
  • We add another config for an apollo-router-2.yaml or similar.

phryneas avatar Sep 20 '24 16:09 phryneas

@jerelmiller can we keep/merge the supergraph schema one (which pretty much never changes and should be safe) and just take out the Router config stuff for now? I don't think I'll have time to fix the red squigglies on connectors features before we want this released.

dylan-apollo avatar Sep 25 '24 15:09 dylan-apollo

@dylan-apollo I've reduced the scope to supergraph.yaml for now - should I get this in?

phryneas avatar Oct 18 '24 11:10 phryneas