Rover dev fails to run if windows user name contains a space
Description
The rover dev command crashes if your windows username contains a space. I believe it is due to some spawned shell processes trying to call an executable path that contains a space, meaning it only grabs the path up till the space.
Steps to reproduce
- Create a windows profile with a username that contains a space.
- Install rover via
iwr 'https://rover.apollo.dev/win/latest' | iex - Run through the retail supergraph example at https://www.apollographql.com/docs/graphos/get-started/guides/quickstart
Expected result
The rover CLI should run the supergraph as normal
Actual result
When running the rover dev command, the rover CLI errors out with an error "C:\Users<Name before space>"
Environment
Run rover info and paste the results here
Version: 0.26.2
Install Location: C:\tools\.rover\bin\rover.exe
OS: Windows 10.0.19045 (Windows 10 Pro) [64-bit]
Shell: Unknown
Note: the rover info above is after moving the installed rover binary and updating the PATH environment variable as an attempted workaround, it was initially installed at C:\Users\Jacob Irving\.rover\bin
Thanks for submitting this bug report.
I think this may be an issue with a dependency, but we should have a fix for this particular issue in the next minor release as we move away from using that dependency in this way.