router icon indicating copy to clipboard operation
router copied to clipboard

Update usage of `shape` crate for 0.7.0-preview.n releases

Open benjamn opened this issue 4 months ago • 2 comments

This PR cherry-picks the crucial [email protected] version update from PR #8143 as a standalone commit (note: previously known as [email protected]), before introducing any abstract types-related changes, which should make these Shape-related updates much easier to review.

This update benefits all ConnectSpec versions, while still allowing us to preserve backwards/forwards compatibility for older versions (connect/v0.3 and earlier). It would be a shame to have to maintain two slightly different shape APIs (colliding on the same cargo package name) in order to keep connect/v0.3 and earlier working as before. Fortunately, we do not need to maintain a fork like that at the level of the shape library.

One of the goals of this commit is to show how limited/reasonable the updates are, because the new functionality coming in [email protected] does not radically alter the behavior of the library (at least not in the ways we were previously using it). Notable (expected) changes: we've started using a shape.locations() method instead of accessing/mutating the shape.locations vector directly, the new shape name tracking system allows better error messages, and shape pretty-printing may now include newlines/indentation for readability.

If this PR looks good and it meets the needs of the Router connectors implementation, I hope it can lend general confidence/support to the [email protected] minor version update, even though I know most of the team has not had a chance to review the upstream changes in detail.

benjamn avatar Nov 14 '25 19:11 benjamn

@benjamn, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Nov 14 '25 19:11 github-actions[bot]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/performance/caching/response-caching/observability.mdx

Build ID: 968574872c6836ae13d038c7 Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/968574872c6836ae13d038c7

apollo-librarian[bot] avatar Nov 17 '25 20:11 apollo-librarian[bot]