router icon indicating copy to clipboard operation
router copied to clipboard

fix: Add validation for incompatible Datadog and trace context propagation

Open abernix opened this issue 6 months ago • 3 comments

Prevents simultaneous activation of Datadog tracing and W3C trace context propagation to avoid trace ID format conflicts.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [x] PR description explains the motivation for the change and relevant context for reviewing
  • [x] PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • [x] Changeset is included for user-facing changes
  • [x] Changes are compatible[^1]
  • [x] Documentation[^2] completed
  • [x] Performance impact assessed and acceptable
  • [x] Metrics and logs are added[^3] and documented
  • Tests added and passing[^4]
    • [x] Unit tests
    • [x] Integration tests, as necessary
    • [x] Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. [^4]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

abernix avatar Jul 08 '25 12:07 abernix

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 3 changed, 0 removed
* graphos/routing/(latest)/observability/telemetry/trace-exporters/overview.mdx
* graphos/routing/(latest)/operations/subscriptions/configuration.mdx
* graphos/routing/(latest)/performance/caching/entity.mdx

Build ID: 19c91de500bbbf2acecf585d

URL: https://www.apollographql.com/docs/deploy-preview/19c91de500bbbf2acecf585d

apollo-librarian[bot] avatar Jul 08 '25 12:07 apollo-librarian[bot]

Putting this back to draft, because many of the integration tests need some work before they'll pass.

abernix avatar Jul 09 '25 17:07 abernix

I'm taking this over

BrynCooke avatar Jul 11 '25 13:07 BrynCooke