router icon indicating copy to clipboard operation
router copied to clipboard

[JSONSelection] Reenable `->` method shape checking and fully implement `math_shape`

Open benjamn opened this issue 10 months ago • 2 comments

Although we have not made them public yet, one precondition for shipping the arithmetic methods (->add, ->sub, ->mul, ->div, and ->mod) is fully implementing the code responsible for statically determining the output "shape" of each method (given input/argument shapes), which in this case is always Int, Float, or possibly a Error if the input/argument shapes are not acceptable.

This PR provides this implementation for math_shape, but in order to make these changes meaningful/testable, I've also included a commit that reenables method shape checking as part of PathList::compute_output_shape, aligning it better with the runtime changes to PathList::apply_to_path from PR #7144, and resolving this open JIRA task (see commit messages for more details).

benjamn avatar Jun 06 '25 15:06 benjamn

@benjamn, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

github-actions[bot] avatar Jun 06 '25 15:06 github-actions[bot]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/guides/index.mdx

Build ID: 190d659627bd970d0c0cf60b

URL: https://www.apollographql.com/docs/deploy-preview/190d659627bd970d0c0cf60b

svc-apollo-docs avatar Jun 06 '25 15:06 svc-apollo-docs

Closing in favor of a forthcoming smaller PR with just the math_shape-related changes.

benjamn avatar Jul 18 '25 21:07 benjamn