router icon indicating copy to clipboard operation
router copied to clipboard

Support unix_ms_now in rhai engine

Open shaikatzz opened this issue 1 year ago • 3 comments

Fixes #5182


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [x] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [x] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

shaikatzz avatar May 16 '24 09:05 shaikatzz

@shaikatzz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar May 16 '24 09:05 apollo-cla

CI performance tests

  • [x] step - Basic stress test that steps up the number of users over time
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • [ ] large-request - Stress test with a 1 MB request payload
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] xxlarge-request - Stress test with 100 MB request payload
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] no-graphos - Basic stress test, no GraphOS.
  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [x] const - Basic stress test that runs with a constant number of users

router-perf[bot] avatar May 16 '24 09:05 router-perf[bot]

Thanks for this PR and for the excellent presentation. I particularly appreciate the test and the docs additions.

Could you also create a changeset (so you get appropriate credit when this is released) following the procedure in .changesets/README.md ? re-request a review from me when you are ready.

Done!

shaikatzz avatar May 22 '24 11:05 shaikatzz

@IvanGoncharov @garypen do you know why the tests are not passing? what else is required in order to merge that PR?

shaikatzz avatar May 28 '24 08:05 shaikatzz

@IvanGoncharov @garypen do you know why the tests are not passing? what else is required in order to merge that PR?

possibly because the CLA wasn't signed. I've just kicked it back into life and we'll see what happens after this run.

garypen avatar May 29 '24 13:05 garypen

@IvanGoncharov @garypen do you know why the tests are not passing? what else is required in order to merge that PR?

I dug into this a little and I think that a change has broken our integration tests so that a PR from a fork will always fail certain integration tests. I'm trying to figure out what has changed so we can fix that and get this merged.

garypen avatar Jun 03 '24 07:06 garypen

@garypen I've signed the CLA, let me know if anything else is needed from my side, i'll be happy to have this change merged :-)

shaikatzz avatar Jun 06 '24 11:06 shaikatzz